I guess rest of the pybind code was already present?

When all of the required libraries and environment variables are set up, it will work with only this change. I would like to further simplify, as there is a lot of setup required - including some copying around of python extension binaries. But this code here is enough to make it runnable in conjunction with the existing QNN CI scripts (which do all of the setup).

as there is a lot of setup required - including some copying around of python extension binaries

Can you elaborate?

as there is a lot of setup required - including some copying around of python extension binaries

Can you elaborate?

Yeah, it looks like it's currently building the Python extension components separately and then copying them into the ET directory. (See https://docs.pytorch.org/executorch/main/backends-qualcomm.html#aot-ahead-of-time-components). As part of the build cleanup and pybind enablement, I'll see if I can fold that into our "main" pybind build. That will also make it just work with installation, wheels, etc.

as there is a lot of setup required - including some copying around of python extension binaries

Can you elaborate?

Yeah, it looks like it's currently building the Python extension components separately and then copying them into the ET directory. (See https://docs.pytorch.org/executorch/main/backends-qualcomm.html#aot-ahead-of-time-components). As part of the build cleanup and pybind enablement, I'll see if I can fold that into our "main" pybind build. That will also make it just work with installation, wheels, etc.

They should be part of ./backends/qualcomm/scripts/build.sh. After you run this script, does pybind work?

as there is a lot of setup required - including some copying around of python extension binaries

Can you elaborate?

Yeah, it looks like it's currently building the Python extension components separately and then copying them into the ET directory. (See https://docs.pytorch.org/executorch/main/backends-qualcomm.html#aot-ahead-of-time-components). As part of the build cleanup and pybind enablement, I'll see if I can fold that into our "main" pybind build. That will also make it just work with installation, wheels, etc.

They should be part of ./backends/qualcomm/scripts/build.sh. After you run this script, does pybind work?

Sort of. It does expect that you're running scripts from the root directory of executorch (or have an editable install), since it puts the extension binaries in the source directory. So it won't work if you're using ET from another directory, such as a dependent project. It should ideally put these binaries wherever the installed copy of the executorch python package is.

If no objection, I'm happy to take this task as part of the build workstream. Basically, running install_executorch.sh with qnn enabled will automatically do what that build.sh script does as part of the main install, in order to make it easy.